Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinetis RTC HAL: Allow writing 0 to the seconds register #5152

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Kinetis RTC HAL: Allow writing 0 to the seconds register #5152

merged 1 commit into from
Sep 29, 2017

Conversation

mmahadevan108
Copy link
Contributor

There is no hardware limitation in writing a 0 value to the seconds register.

@mmahadevan108
Copy link
Contributor Author

cc @0xc0170 @c1728p9 @mprse

@mmahadevan108 mmahadevan108 mentioned this pull request Sep 20, 2017
Closed
0xc0170
0xc0170 approved these changes Sep 20, 2017
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe KLxxx have the same t == 1 condition

@mprse
Copy link
Contributor

mprse commented Sep 21, 2017

@mmahadevan108 @0xc0170
The following files are affected by this issue:
/m-bed/targets/TARGET_Freescale/TARGET_K20XX/rtc_api.c
/m-bed/targets/TARGET_Freescale/TARGET_KLXX/rtc_api.c
/m-bed/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/api/rtc_api.c
/m-bed/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/api/rtc_api.c

Maybe we should also clear potential overflow/invalid flags after RTC time is set to 0?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2017

The following files are affected by this issue:
/m-bed/targets/TARGET_Freescale/TARGET_K20XX/rtc_api.c
/m-bed/targets/TARGET_Freescale/TARGET_KLXX/rtc_api.c
/m-bed/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/api/rtc_api.c
/m-bed/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/api/rtc_api.c

@mmahadevan108 Can you please fix all those RTC implementation within this patch?

@mmahadevan108
RTC HAL: Allow writing 0 to the seconds register
1dadb05 
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
@mmahadevan108
Copy link
Contributor Author

Fixed the other RTC implementations as well.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 29, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1432

All builds and test passed!

@theotherjimmy theotherjimmy merged commit f5bb15f into ARMmbed:master Sep 29, 2017
@mmahadevan108 mmahadevan108 deleted the Update_RTC_HAL_driver branch September 30, 2017 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmahadevan108 @mprse @0xc0170 @mbed-bot @theotherjimmy